Add selection tolerance#3659
Closed
Nuhiat-Arefin wants to merge 1 commit intoGraphiteEditor:masterfrom
Closed
Conversation
Nuhiat-Arefin
force-pushed
the
Add-Selection-Tolerance
branch
2 times, most recently
from
c71ef03 to
9f5acea
Compare
Keavon
force-pushed
the
Add-Selection-Tolerance
branch
from
9f5acea to
e8c4a04
Compare
Member
|
Sorry it took so long to reach this in my PR review queue! Upon taking a closer look, this doesn't solve the problem, and I believe your reproduction steps (shown in your videos) show a misunderstanding of the problem, since each of those are shapes with a (white) fill area which doesn't even apply to this situation. This implementation breaks the relationship between hover targets (when the shape that will be clicked lights up) and click targets (when clicking actually selects the shape). I also took a closer look at the original issue report and I am not sure if it actually needs to be changed from its current form. Anyway, thank you for your attempt and hopefully you learned something in the process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2141
Modified the intersect_point function in click_target.rs. If the stroke (as measured in viewport space) is very thin(less than 5px) it calculates inflated_stroke such that the stroke as measured in viewport space is 5px. Otherwise, it keeps the value of the original stroke.
Before:
Screen.Recording.2026-01-24.at.2.06.55.PM.mov
After:
Screen.Recording.2026-01-24.at.2.10.26.PM.1.mov
With larger inflation:
Screen.Recording.2026-01-24.at.3.01.53.PM.mov